This repository was archived by the owner on Oct 19, 2021. It is now read-only.
Refactor binding + testing infrastructure #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbranyen
force-pushed
the
add-testing-infra
branch
3 times, most recently
from
99107d9 to
cb4ac68
Compare
|
Hey @gnarf I kind of expanded this PR, but now I'm only ever binding one transition state handler per type. Plus one for special handling of attached and then the one to track attributes being added. Instead of binding a handler it now adds the element to a whitelist along with the handler. This makes it easier to add/remove. There might be a performance benefit to this, but I doubt it's super substantial. |
tbranyen
changed the title
This whitelists elements with handlers and registers constant transition hooks. There is now the ability to undo the inline transitions. I got the testing coverage to 100%. Looks good to me!
tbranyen
force-pushed
the
add-testing-infra
branch
from
1a06609 to
82146ca
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.