Skip to content

Conversation

styfle
Copy link
Member

@styfle styfle commented Sep 8, 2025

In PR #12 we changed the type from buffer to bytes again and the output was changed from ArrayBuffer to Uint8Array, but the spec was not updated.

This PR updates the spec to match the readme.

Copy link

github-actions bot commented Sep 8, 2025

The rendered spec for this PR is available at https://tc39.es/proposal-import-bytes/pr/20.

@styfle
Copy link
Member Author

styfle commented Sep 8, 2025

Seems I can't add reviewers to this PR so I'll tag @guybedford @eemeli @jasnell @nicolo-ribaudo 😃

@styfle styfle mentioned this pull request Sep 8, 2025
28 tasks
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 128 we should now create a Uint8Array, right?

@guybedford
Copy link
Contributor

@nicolo-ribaudo yes, I've also posted #21 for this. I think it makes sense as a separate PR.

@styfle styfle merged commit 24c9c8d into main Sep 9, 2025
1 check passed
@styfle styfle deleted the styfle/update-spec-bytes branch September 9, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants