Define URLs and paths for the 'Create' pages #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we start to move from our current use of modal dialogs for the create pages (PipelineResource, PipelineRun, Secret, and soon TaskRun) to a full-page experience, we need to ensure we have a consistent URL strategy for these pages. Define a set of `/<kind>/create` URLs and paths to use for this purpose, e.g. the Create PipelineResource UI would be at `/pipelineresources/create` Also reorder the definitions and tests alphabetically to make it easier to work with them. I found myself jumping around (to the wrong part of the file) far too often.
tekton-robot
added
the
size/L
AlanGreene
requested review from
a-roberts and
steveodonovan
and removed request for
CarolynMabbott and
Megan-Wright
a-roberts
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Also reorder the definitions and tests alphabetically to make
it easier to work with them. I found myself jumping around (to
the wrong part of the file) far too often.
+1
Changes look good, @CarolynMabbott FYI as I know you've been looking into having the secrets create on its own page too
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-roberts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#966
As we start to move from our current use of modal dialogs for
the create pages (PipelineResource, PipelineRun, Secret, and soon TaskRun)
to a full-page experience, we need to ensure we have a consistent
URL strategy for these pages.
Define a set of
/<kind>/createURLs and paths to use for this purpose,e.g. the Create PipelineResource UI would be at
/pipelineresources/createAlso reorder the definitions and tests alphabetically to make
it easier to work with them. I found myself jumping around (to
the wrong part of the file) far too often.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.