Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-0079] Add Support Tier in tkn hub install command #759

Closed
wants to merge 3 commits into from
Closed

[TEP-0079] Add Support Tier in tkn hub install command #759

wants to merge 3 commits into from

Conversation

QuanZhang-William
Copy link
Member

@QuanZhang-William QuanZhang-William commented Jan 9, 2023 •
edited
Loading

Changes

Part of #691 and based on #757. Prior to this change, no support tier, catalog or org information was added to the resource annotation when installing from Hub.

This commit adds artifacthub.io/catalog, "artifacthub.io/org" and "artifacthub.io/support-tier" labels to the resource being installed to indicate the source and support tier of the catalog. The 3 labels will only be added when installing with --type artifact flag.

Details can be found in https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md#cli

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
  • Run UI Unit Tests, Lint Checks with make ui-check
  • Commit messages follow commit message best practices

See the contribution guide for more details.

@QuanZhang-William
Refactor get_resource and get_resource_version for multiple hub support
4eede25 
No functionality change in this PR. Prior to this change, the Hub CLI supports only 1 type of Hub (Tekton Hub).

This commit 1) refactors the `ResourceResult` and `ResourceVersionResult` to interfaces;
2) creates THResourceResult and THResourceVersionResult structs implementing the interfaces, keeping original support for Tekton Hub;
3) creates AHResourceResult and AHResourceVersionResult for Artifact Hub, implementations will be added in later PRs.
@QuanZhang-William
Implement "install" command for artifact type
3108ac7 
Prior to this commit, the tkn hub install command is only supported with --type tekton. This commit adds the tkn hub install functionality for --type artifact, which fetches resources from the Artifact Hub and install to user's cluster.

Example:
tkn hub install task golang-build --from tekton-catalogs-task --version 0.2.0
@QuanZhang-William
[TEP-0079] Add Support Tier in tkn hub install command
e513e17 
Part of tektoncd#691. Prior to this change, no support tier, catalog or org information was added to the resource annotation when installing from Hub.

This commit adds `artifacthub.io/catalog`, "artifacthub.io/org" and "artifacthub.io/support-tier" labels to the resource being installed to indicate the source and support tier of the catalog. The 3 labels will only be added when installing with `--type artifact` flag.

Details can be found in https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md#cli
@tekton-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pratap0007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @pratap0007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 9, 2023
@QuanZhang-William
Copy link
Member Author

Part of #691

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2023
@tekton-robot
Copy link

@QuanZhang-William: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QuanZhang-William
Copy link
Member Author

/close this pr for too much rebase work.

Please check #775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuanZhang-William @tekton-robot