[TEP-0079] Add Support Tier in tkn hub install command #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
4 tasks
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
pratap0007
reviewed
Jan 25, 2023
Part of tektoncd#691. Prior to this change, no support tier, catalog or org information was added to the resource annotation when installing from Hub. This commit adds `artifacthub.io/catalog`, "artifacthub.io/org" and "artifacthub.io/support-tier" labels to the resource being installed to indicate the source and support tier of the catalog. The 3 labels will only be added when installing with `--type artifact` flag. Details can be found in https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md#cli
QuanZhang-William
force-pushed
the
tep-0079-support-tier-label
branch
from
10b3a62
to
b4d98f0
Compare
|
/lgtm |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #691. Prior to this change, no support tier, catalog or org information was added to the resource annotation when installing from Artifact Hub.
This commit adds
artifacthub.io/catalog,artifacthub.io/organdartifacthub.io/support-tierlabels to the resource being installed to indicate the source and support tier of the catalog. The 3 labels will only be added when installing with--type artifactflag.Details can be found in https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md#cli
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make api-checkmake ui-checkSee the contribution guide for more details.