-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation of embedded TaskSpec in a TaskRun #1084
Add validation of embedded TaskSpec in a TaskRun #1084
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ah the failure will go away with #1081 in 👼 I'll rebase once merged |
f10409b
to
e30e1f8
Compare
Hahaha so much validation that we weren't calling! ( cc @EliZucker XD) Probably at least a bit my fault for being so unit test focused :D @vdemeester can we add some test coverage as well? |
Yes definitely 👼 But I face a interesting failure though : |
o boy |
If a `TaskRun` embeddeds a Task spec (using `taskSpec` instead of `taskRef`) we should validate the `TaskSpec` too. It fixes supports validation for unmamed steps too. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
e30e1f8
to
4cec444
Compare
Fixed 🎉 It also fixes support for unnamed steps 😅 |
Great find @vdemeester ! /lgtm |
Oh yeah this is super similar to #1074! /lgtm |
Changes
If a
TaskRun
embeddeds a Task spec (usingtaskSpec
instead oftaskRef
) we should validate theTaskSpec
too./cc @bobcatfish
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task and TaskRun to build and release this image
Release Notes