Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly release on latest tekton #1422

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Nightly release on latest tekton #1422

merged 1 commit into from
Oct 23, 2019

Conversation

afrittoli
Copy link
Member

Changes

Change the nightly release jobs so that they may run on the latest tekton.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

@afrittoli
Copy link
Member Author

/hold

@tekton-robot tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2019
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Oct 14, 2019
@afrittoli
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@afrittoli
Copy link
Member Author

This will need rebasing eventually - but before this can be used, we need to have cron jobs and logging working in the dogfooding cluster.

@afrittoli afrittoli force-pushed the nightly_release_on_latest_tekton branch from 964b427 to ead695c Compare October 18, 2019 12:06
@afrittoli
Add a tekton v0.7.0 version of the nightly release
993fb9f 
Create a new version of the nightly-release that is identical to
the full release, except for the following:
- no release pre-check is executed
- a new ko image is built (using a v0.7.0 compatible task)
- the default image registry is gcr.io/tekton-nightly

This version can be executed via triggers on the dogfooding
cluster. This commit leaves the existing nightly release untouched
so that it can be executed via prow, until we are ready to
finalize the switch to the dogfooding cluster for nightly.
@afrittoli afrittoli force-pushed the nightly_release_on_latest_tekton branch from ead695c to 993fb9f Compare October 18, 2019 15:22
@afrittoli
Copy link
Member Author

I've rewritten this so that it does not modify the original nightly pipeline. We can keep running the v0.3.1 compatible pipeline via prow in the prow cluster until we have a solution in place for logging in the dogfooding cluster. This is already running there on a daily basis, but the artifacts are published to the staging bucket and gcr repo for now, until logging is sorted out.

@afrittoli
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2019
dibyom
dibyom reviewed Oct 22, 2019
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
vdemeester
vdemeester approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@tekton-robot tekton-robot merged commit ad69254 into tektoncd:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@vdemeester vdemeester

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@afrittoli @tekton-robot @vdemeester @dibyom @googlebot