Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PodStatus->TaskRunStatus code to pkg/pod #1627

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Move PodStatus->TaskRunStatus code to pkg/pod #1627

merged 1 commit into from
Nov 27, 2019

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Nov 26, 2019 •
edited
Loading

This allows us to unexport more helper functions, and centralizes the other half of Pod<->TaskRun conversion into pkg/pod.

Some consts are still exported, but I think those might be useful to
some callers anyway.

#1605

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Nov 26, 2019
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 26, 2019
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 74.9% 74.8% -0.1

@imjasonh
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

1 similar comment
@imjasonh
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@imjasonh
Move PodStatus->TaskRunStatus code to pkg/pod
f7f1e14 
This allows us to unexport more helper functions.

Some consts are still exported, but I think those might be useful to
some callers anyway.
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 74.9% 74.8% -0.1

vdemeester
vdemeester approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019
@bobcatfish
Copy link
Collaborator

LGTM :)

not sure if ironic or waiting to be picked up by cool new tekton dogfooding automation

image

@vdemeester
Copy link
Member

/lgtm
/meow

😝

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/lgtm
/meow

😝

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2019
@tekton-robot tekton-robot merged commit 6f6d7bf into tektoncd:master Nov 27, 2019
JeromeJu added a commit to JeromeJu/pipeline that referenced this pull request Nov 22, 2023
@JeromeJu
Remove unused ReasonCouldntGetTask
224ef80 
This commit removes the unused pod.ReasonCouldntGetTask.
ReasonCouldntGetTask has been moved from reconciler to pod/status pkg
via tektoncd#1627. The reference to it has been removed since tektoncd#6295.

/kind cleanup
JeromeJu added a commit to JeromeJu/pipeline that referenced this pull request Nov 22, 2023
@JeromeJu
Remove unused ReasonCouldntGetTask
eb01d5d 
This commit removes the unused pod.ReasonCouldntGetTask.
ReasonCouldntGetTask has been moved from reconciler to pod/status pkg
via tektoncd#1627. The reference to it has been removed since tektoncd#6295.

/kind cleanup
JeromeJu added a commit to JeromeJu/pipeline that referenced this pull request Nov 22, 2023
@JeromeJu
Remove unused ReasonCouldntGetTask
c9b11ac 
This commit removes the unused pod.ReasonCouldntGetTask.
ReasonCouldntGetTask has been moved from reconciler to pod/status pkg
via tektoncd#1627. The reference to it has been removed since tektoncd#6295.

/kind cleanup
JeromeJu added a commit to JeromeJu/pipeline that referenced this pull request Nov 23, 2023
@JeromeJu
Remove unused ReasonCouldntGetTask
ff59bae 
This commit removes the unused pod.ReasonCouldntGetTask.
ReasonCouldntGetTask has been moved from reconciler to pod/status pkg
via tektoncd#1627. The reference to it has been removed since tektoncd#6295.

/kind cleanup
tekton-robot pushed a commit that referenced this pull request Nov 29, 2023
@JeromeJu @tekton-robot
Remove unused ReasonCouldntGetTask
31fa585 
This commit removes the unused pod.ReasonCouldntGetTask.
ReasonCouldntGetTask has been moved from reconciler to pod/status pkg
via #1627. The reference to it has been removed since #6295.

/kind cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@imjasonh @tekton-robot @bobcatfish @vdemeester @googlebot