add optional comment on fields

[nader-ziada]

fixes #17

Proposed Changes

• add +optional comment on fields that have omitempty

[bobcatfish]

Nice one, thanks @pivotal-nader-ziada ! Now that I'm looking at the api conventions a little more closely, it looks like these optional values should also have a pointer type 🤔 no worries if you'd rather we do that in a separate issue tho (i totally missed it the first time around)

Before we merge this would you be able to add a bit more detail to the commit message around why we're making this change?

/lgtm
/approve
/hold

/meow space

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish, pivotal-nader-ziada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bobcatfish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow-robot]

@bobcatfish:

In response to this:

Nice one, thanks @pivotal-nader-ziada ! Now that I'm looking at the api conventions a little more closely, it looks like these optional values should also have a pointer type 🤔 no worries if you'd rather we do that in a separate issue tho (i totally missed it the first time around)

Before we merge this would you be able to add a bit more detail to the commit message around why we're making this change?

/lgtm
/approve
/hold

/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nader-ziada]

@bobcatfish
I see the api convention says the optional field should be a pointer, but that's only for fields that can not have a nil value. I changed a couple of types to be pointers, but most of the optional fields here are string or a spec type which in both serving and Kubernetes itself are not pointers. WDYT?

I changed the commit message, but that means you have to approve again :)

[nader-ziada]

/hold cancel

[tejal29]

/lgtm
Thanks for the follow up!