Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: delete duplicate words. #5923

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Cleanup: delete duplicate words. #5923

merged 1 commit into from
Dec 28, 2022

Conversation

bendory
Copy link
Contributor

@bendory bendory commented Dec 28, 2022

Changes

Cleanup: delete duplicate words.

There are no expected functional changes in this PR.

The code changes are duplicate words discovered by the dupword linter, for example,
the the --> the. Occasional deduped words appear in unit test strings where I've uniqified the words in question.

The dupword linter will be enabled in
#5918.

Context: #5899

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [N/A] Has Docs included if any changes are user facing
  • [N/A] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [N/A] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [N/A] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

There are no expected functional changes in this PR.

The code changes are duplicate words discovered by the `dupword` linter,
for example, `the the` --> `the`. Occasional deduped words appear in
unit test strings where I've uniqified the words in question.

The `dupword` linter will be enabled in
#5918.

Context: #5899

/kind cleanup
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 28, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 28, 2022
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 28, 2022
@abayer
Copy link
Contributor

abayer commented Dec 28, 2022

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2022
@tekton-robot tekton-robot merged commit 14ccac5 into tektoncd:main Dec 28, 2022
@bendory bendory deleted the dedup branch December 28, 2022 18:12
tekton-robot pushed a commit that referenced this pull request Dec 29, 2022
Given cleanup in #5923, there
are no required code changes for this linter to lint clean.

Context: #5899

/kind cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants