Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0118: Added Matrix.Include field in preview mode #6188

Merged
merged 1 commit into from
Feb 23, 2023
Merged

TEP-0118: Added Matrix.Include field in preview mode #6188

merged 1 commit into from
Feb 23, 2023

Conversation

EmmaMunley
Copy link
Contributor

@EmmaMunley EmmaMunley commented Feb 17, 2023 •
edited
Loading

Changes

TEP-0118 proposed adding include as a new field within matrix

In this change, we add the matrix.Include field to the matrix specification and documentation the API change - we will incrementally add further details as we iterate on the implementation of TEP-0118 to allow specify specific combinations or explicit combinations for Matrix Parameters. Validation and implementation logic will be added in subsequent PRs.

Note: This PR is to only add the new Matrix.Include field and update the documentation in "Preview Mode". No functionality has been added at this time.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

API Change: Added Matrix.Include in preview mode (Not yet functional)

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 17, 2023
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 17, 2023
@EmmaMunley EmmaMunley mentioned this pull request Feb 17, 2023
Closed
6 tasks
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 17, 2023
pritidesai
pritidesai approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @EmmaMunley 👍 Exciting to have this feature implemented ... 🎉

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
jerop
jerop reviewed Feb 22, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @EmmaMunley!

Requesting some docs changes, otherwise looks good to me

docs/pipeline-api.md Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1/pipeline_types.go Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1beta1/pipeline_types.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2023
@pritidesai
Copy link
Member

@EmmaMunley please fix the commits, its messed up with 14 commits 😞

@EmmaMunley EmmaMunley closed this Feb 22, 2023
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 22, 2023
@EmmaMunley
Copy link
Contributor Author

/Reopen

@EmmaMunley EmmaMunley reopened this Feb 22, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jerop
jerop reviewed Feb 22, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmmaMunley changes look good to me, but please update the commit message with more detail - https://github.com/tektoncd/community/blob/main/standards.md#commit-messages

@EmmaMunley
TEP-0118: Added Matrix.Include field in preview mode
43c0d69 
In this change, we add the matrix.Include field to the matrix specification and documentation the API change - we will incrementally add further details as we iterate on the implementation of TEP-0118 to allow specify specific combinations or explicit combinations for Matrix Parameters. Validation and implementation logic will be added in subsequent PRs.
jerop
jerop reviewed Feb 23, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@tekton-robot tekton-robot merged commit 8b78f70 into tektoncd:main Feb 23, 2023
@EmmaMunley EmmaMunley deleted the include-matrix-preview-mode branch February 23, 2023 19:06
@EmmaMunley EmmaMunley mentioned this pull request Feb 27, 2023
Closed
7 tasks
@EmmaMunley EmmaMunley mentioned this pull request Mar 13, 2023
Closed
16 tasks
@QuanZhang-William QuanZhang-William mentioned this pull request Sep 29, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop left review comments

@pritidesai pritidesai pritidesai approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmmaMunley @pritidesai @tekton-robot @jerop