Remove third_party directory #6416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
do-not-merge/work-in-progress
tekton-robot
added
the
size/S
lbernick
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
This commit removes the third_party directory, and updates hack/update-deps.sh to not store licenses in the third_party directory. It also removes symlinks to third_party in the kodata folders of code in cmd/, which results in third_party not being included in the images built from these directories. The default build_test runner validates licenses stored in the vendor directory (https://github.com/tektoncd/plumbing/blob/c6cc7570d1254ac6796b08f20adcaf10a80d38a4/scripts/presubmit-tests.sh#L205-L208). The reason we have the third_party directory is because some of our dependencies may have licenses that require distributing source code along with built images. However, we already include the (compressed) vendor directory in built images (see the [release pipeline](https://github.com/tektoncd/pipeline/blob/bf26bfb35745b403ac8ca760068f4d102e441940/tekton/publish.yaml#L139-L152)). The reason to remove third_party is because it is redundant with the vendor directory, included in unit tests, and CI does not enforce keeping it up to date. As an alternative to this commit, we could instead enforce that third_party is kept up to date via hack/verify-codegen.sh.
|
/retest |
tekton-robot
added
the
approved
dibyom
approved these changes
Mar 22, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, vdemeester, wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7 tasks
7 tasks
4 tasks
dibyom
added a commit
to dibyom/triggers
that referenced
this pull request
Apr 19, 2023
The third_party directory contains source code of some of our third_party dependencies that need to be distributed with the built images as required by their licenses. However, our publish-triggers-release task [1] already includes the source code of all of our dependencies in the image rendering the separate third_party directory redundant. This is a port of tektoncd/pipeline#6416 [1] https://github.com/tektoncd/triggers/blob/2713832b025b804db4d8d7af48e4f944511b490f/tekton/publish.yaml#L104-L117 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
4 tasks
dibyom
added a commit
to dibyom/triggers
that referenced
this pull request
May 12, 2023
The third_party directory contains source code of some of our third_party dependencies that need to be distributed with the built images as required by their licenses. However, our publish-triggers-release task [1] already includes the source code of all of our dependencies in the image rendering the separate third_party directory redundant. This is a port of tektoncd/pipeline#6416 [1] https://github.com/tektoncd/triggers/blob/2713832b025b804db4d8d7af48e4f944511b490f/tekton/publish.yaml#L104-L117 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
tekton-robot
pushed a commit
to tektoncd/triggers
that referenced
this pull request
May 31, 2023
The third_party directory contains source code of some of our third_party dependencies that need to be distributed with the built images as required by their licenses. However, our publish-triggers-release task [1] already includes the source code of all of our dependencies in the image rendering the separate third_party directory redundant. This is a port of tektoncd/pipeline#6416 [1] https://github.com/tektoncd/triggers/blob/2713832b025b804db4d8d7af48e4f944511b490f/tekton/publish.yaml#L104-L117 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the third_party directory, and updates hack/update-deps.sh to not store licenses in the third_party directory. It also removes symlinks to third_party in the kodata folders of code in cmd/, which results in third_party not being included in the images built from these directories.
The default build_test runner validates licenses stored in the vendor directory.
The reason we have the third_party directory is because some of our dependencies may have licenses that require distributing source code along with built images. However, we already include the (compressed) vendor directory in built images (see the release pipeline).
The reason to remove third_party is because it is redundant with the vendor directory, included in unit tests, and CI does not enforce keeping it up to date. As an alternative to this commit, we could instead enforce that third_party is kept up to date via hack/verify-codegen.sh (the approach taken by #6342).
/kind misc
Closes #6210
Closes #6352
Closes #6015
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes