[TEP-0074] Remove git-init code #6417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/cleanup
vdemeester
approved these changes
Mar 22, 2023
tekton-robot
added
the
approved
This commit removes cmd/git-init and pkg/git, both of which are used only for the git-init image. The git-init image is no longer built and released along with Pipelines. As part of TEP-0079 (Catalog support tiers), this code will be moved into a new repo in the tektoncd-catalog org, where it will be used for the git-clone and git-batch-merge official Tasks. This code can still be added to a new repo (by copying from the parent of this commit), and removing it reduces the maintenance burden for Pipelines and unblocks removal of PipelineResources related code. The latest published version of the git-init image is currently used in examples tests. Examples tests will be updated to use remote resolution from the catalog in a separate commit.
dibyom
approved these changes
Mar 22, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes cmd/git-init and pkg/git, both of which are used only for the git-init image. The git-init image is no longer built and released along with Pipelines, as of #6150. As part of TEP-0079 (Catalog support tiers), this code will be moved into a new repo in the tektoncd-catalog org, where it will be used for the git-clone and git-batch-merge official Tasks. This code can still be added to a new repo (by copying from the parent of this commit), and removing it reduces the maintenance burden for Pipelines and unblocks removal of PipelineResources related code (#6301 is blocked; #6335 is an alternative to this PR).
The latest published version of the git-init image is currently used in examples tests. Examples tests will be updated to use remote resolution from the catalog in a separate commit (tracked in #5727).
/kind cleanup
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes