Fix latest folder in releases #7146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gcs-upload task by default uses "gsutil cp -r" to copy the
local folder with release files to the latest folder.
That works well if "latest" does not exists, otherwise it creates
a "<version>" folder into "latest", which is not the desired
behaviour.
The "deleteExtraFiles" flag in the task means that "gsutil rsync -r"
is used instead, which achieves the correct behaviour in all
cases ("latest" exists or not.
Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XS
vdemeester
approved these changes
Sep 25, 2023
tekton-robot
added
the
approved
imjasonh
approved these changes
Sep 25, 2023
JeromeJu
approved these changes
Sep 26, 2023
jerop
approved these changes
Sep 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: imjasonh, JeromeJu, jerop, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/easycla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The gcs-upload task by default uses "gsutil cp -r" to copy the local folder with release files to the latest folder.
That works well if "latest" does not exists, otherwise it creates a "" folder into "latest", which is not the desired behaviour.
The "deleteExtraFiles" flag in the task means that "gsutil rsync -r" is used instead, which achieves the correct behaviour in all cases ("latest" exists or not.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind misc