Refactor nightly builds #714
Conversation
tekton-robot
added
the
size/L
|
I test this ok for pipeline in the tekton-nightly namespace. |
|
/test plumbing-golang-lint |
|
/test plumbing-yamllint |
|
A number of resources required for release purposes are deployed manually: secrets, the project specific task and pipelines, the tasks from the catalogue... this is also a chance to check what's missing, what we could automate further and what needs to be documented. |
|
/hold |
tekton-robot
added
the
do-not-merge/hold
afrittoli
force-pushed
the
nightly_builds
branch
2 times, most recently
from
db12658
to
70cb633
Compare
|
Waiting for tektoncd/triggers#950 |
|
/test plumbing-yamllint |
|
/test plumbing-golang-lint |
afrittoli
force-pushed
the
nightly_builds
branch
from
70cb633
to
b4b2bb4
Compare
| apiVersion: tekton.dev/v1beta1 | ||
| kind: Task | ||
| metadata: | ||
| name: golang-build |
There was a problem hiding this comment.
not sure why we want to duplicate this here vs applying the version in the catalog?
There was a problem hiding this comment.
I should have left a comment on this 🙏
The version in the catalogue is different, this one uses pipeline resources, and the only place it exists today is in the cluster :(
I do want to remove all pipeline resources from the release process, but that's a good sized chunk of work by itself, so I'll be working on that in another series of PRs.
There was a problem hiding this comment.
Yep discussed with @afrittoli, the goal is to not have those anymore but for now, we should make sure all that is on the cluster is stored here. And then we can migrate to depend on the catalog version.
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
|
/test check-pr-has-kind-label |
afrittoli
force-pushed
the
nightly_builds
branch
2 times, most recently
from
d334ea8
to
75ee76d
Compare
Refactor nightly builds to: - move nightly builds to an own namespace - use a single event listener for all nightly builds - use independent trigger CRDs for each project - make it easier to add new builds - pull project specific resources from the project repos The golang tasks where not defined anywhere, so adding them here. Once we switch to release pipelines without pipeline resources, we can start using the version of those tasks from the catalog. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
afrittoli
force-pushed
the
nightly_builds
branch
from
75ee76d
to
bc46c58
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test plumbing-yamllint |
|
/test plumbing-kubectl-build |
|
/test check-pr-has-kind-label |
|
/code plumbing-yamllint |
|
/test plumbing-yamllint |
| @@ -4,9 +4,8 @@ commonLabels: | |||
| commonAnnotations: | |||
| release: nightly | |||
| resources: | |||
| - bindings.yaml | |||
There was a problem hiding this comment.
Should we keep binding.yaml file here like template.yaml ?
There was a problem hiding this comment.
bindings.yaml is not in the base folder anymore, it's now in the root folder, because with this change bindings are not project specific anymore. I'm try to reduce the number of files to be customised when adding a new project to nightly builds.
| @@ -0,0 +1,22 @@ | |||
| # Copyright 2020 The Tekton Authors | |||
There was a problem hiding this comment.
| # Copyright 2020 The Tekton Authors | |
| # Copyright 2021 The Tekton Authors |
There was a problem hiding this comment.
Nice catch, thank you.
I copied that from tekton/resources/nightly-release/base/kustomizeconfig/eventlistener.yaml which is why the copyright is 2020, I can update it if you prefer so.
There was a problem hiding this comment.
Ah okok i got it
I though its added newly
If it's copied from other place then i am okay with 2020
Changes
Refactor nightly builds to:
Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
/kind misc