Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Will your extension support folder .vscode/settings.json on a workspace? #64

Closed
gusbemacbe opened this issue Jan 3, 2022 · 3 comments

Comments

@gusbemacbe
Copy link

Hello!

On a specific project with a folder .vscode on a workspace, I would not like to add MarkdownPaste.path setting to the global user settings, because it would be boring to always change the path in MarkdownPaste.path at the global user setting.

For example, on a global user settings.json:

{
  "MarkdownPaste.path": "${fileDirname}/blabla/images/"
}

On a specific project's folder containing .vscode/settings.json:

{
  "MarkdownPaste.path": "${fileDirname}/blabla/assets/images/examples"
}

When I press Ctrl/Cmd + Alt + V, I have to rename and type always assets/images/examples, because of "MarkdownPaste.path": "${fileDirname}/blabla/images/", but I find it too tired, and it is not supported for folder settings on a workspace. I do not want to apply "MarkdownPaste.path": "${fileDirname}/blabla/assets/images/examples" to the global user settings, because it is for the specific project and not for all projects.

You can analyse the screenshot, observing the tree:

image

@telesoho
Copy link
Owner

telesoho commented Jan 3, 2022

@gusbemacbe

https://code.visualstudio.com/docs/getstarted/settings

image

According to Microsoft's documentation, the workspace settings will always override the user's public settings. If you don't want workspace setting, you should remove it.

@gusbemacbe
Copy link
Author

According to Microsoft's documentation, the workspace settings will always override the user's public settings. If you don't want workspace setting, you should remove it.

I do not mean the workspace settings; I want to override the user settings with a project root folder (.vscode/settings.json). But your extension does not support to override the project root folder on a workspace with the user settings.

Only on an explorer (without workspace), your extension supports to override the project root folder settings with the user settings.

Compare that image above (with workspace) with the image below (without workspace):

image

You can see "Open Folder" (your extensions supports) and "Add Folder to Workspace" (your extension does not support):

image

Remember not to confound project root folder containing .vscode/settings.json with Workspace settings.

You can see how @valentjn's vscode-ltex supports project root folder settings both with or without a workspace. You can see the image above that "ltex.language": "pt-PT" is enabled at .vscode/settings.json on a project on a workspace. Yours is not enabled because your extension does not support.

@gusbemacbe
Copy link
Author

It works fully. Impeccable!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants