Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Skeleton Provider to support rounded corners on Image skeleton #425

Closed
viktorbilyk opened this issue Dec 10, 2020 · 0 comments · Fixed by #426
Closed

Update Skeleton Provider to support rounded corners on Image skeleton #425

viktorbilyk opened this issue Dec 10, 2020 · 0 comments · Fixed by #426

Comments

@viktorbilyk
Copy link
Contributor

Problem statement

  • We would like to update SkeletonProvider to include support for rounded corners on <Image /> skeleton. Existing version only provides circular skeleton for the images

Recommendation

  • To introduce automatic switching between <Image /> skeleton styles by making skeleton aware of rounded prop values

Design intent

As a user I want to be informed when content on the page is loading. I want mock content to match actual content that will be displayed when loading is finished.

Designs

Sample loading state:
Loading State

Acceptance criteria

This section is intentionally left blank. See story writing process.

Meta

  • Include component name and version: v3.0.0
  • Willing to design solution: Yes
  • Willing to develop solution: Yes
  • Has workaround: No
  • Do any similar components already exist in TDS (core or community): Yes
  • Which teams/applications do you think would use this improvement? NES and EXE teams. Bundle Builder and E-Shop Core applications
  • High impact: No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant