Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(community-skeleton-provider): add rounded corners to image skeleton #426

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

viktorbilyk
Copy link
Contributor

@viktorbilyk viktorbilyk commented Dec 10, 2020

Related issues

See #425

Description

This PR adds ability to create image skeleton with rounded corners.

Checklist before submitting pull request

  • Commits follow our Developer Guide
  • New code is unit tested
  • make sure visual and accessibility tests pass
  • make sure code builds

@TDSBot
Copy link

TDSBot commented Dec 10, 2020

Packages pending updates:

- @tds/community-skeleton-provider: 2.0.6 => 3.0.0

If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

Copy link
Contributor

@affansajid affansajid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, we can update the commit change so that it's not a breaking change. This should be good for a feature bump @tds/community-skeleton-provider: 2.0.6 => 2.1.0

@viktorbilyk
Copy link
Contributor Author

The PR looks good, we can update the commit change so that it's not a breaking change. This should be good for a feature bump @tds/community-skeleton-provider: 2.0.6 => 2.1.0

@affansajid I can update PR, so we don't use shared styles library and border-radius is fixed at 4px that way it's not a breaking change. Otherwise, shared styles needs to be included, so I believe it should be marked as breaking change. Other option is I can just amend commit message without any other changes. Please let me know, what option you think is preferable

@jraff
Copy link
Contributor

jraff commented Dec 14, 2020

@viktorbilyk adding @tds/shared-styles by itself is not a breaking change.

Please see https://tds.telus.com/contributing/developer-guide.html#commit-format for guidelines around breaking changes, minor patches, and fixes.

@TDSBot
Copy link

TDSBot commented Dec 14, 2020

Packages pending updates:

- @tds/community-skeleton-provider: 2.0.6 => 2.1.0

If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@viktorbilyk
Copy link
Contributor Author

@jraff Ok, I have amended the commit, so it is not a breaking change anymore

@viktorbilyk viktorbilyk dismissed affansajid’s stale review December 14, 2020 21:27

Comments resolved. file version is outdated

@jraff jraff merged commit a0304f2 into master Dec 15, 2020
@jraff jraff deleted the update-skeleton-provider branch December 15, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Skeleton Provider to support rounded corners on Image skeleton
4 participants