-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(community-skeleton-provider): add rounded corners to image skeleton #426
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good, we can update the commit change so that it's not a breaking change. This should be good for a feature bump @tds/community-skeleton-provider: 2.0.6 => 2.1.0
@affansajid I can update PR, so we don't use shared styles library and border-radius is fixed at 4px that way it's not a breaking change. Otherwise, shared styles needs to be included, so I believe it should be marked as breaking change. Other option is I can just amend commit message without any other changes. Please let me know, what option you think is preferable |
@viktorbilyk adding Please see https://tds.telus.com/contributing/developer-guide.html#commit-format for guidelines around breaking changes, minor patches, and fixes. |
f04de16
to
42bf1a5
Compare
|
@jraff Ok, I have amended the commit, so it is not a breaking change anymore |
Comments resolved. file version is outdated
Related issues
See #425
Description
This PR adds ability to create image skeleton with rounded corners.
Checklist before submitting pull request