Add WorkflowImplementationOptions.setLocalActivityOptions (#975) #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#975) Following existing WorkflowImplementationOptions.setActivityOptions, allow user to define local activity options for different types of activities instead of defining them in workflow code.
imalao
requested review from
Spikhalskiy,
Sushisource,
bergundy,
cretz,
mfateev and
mmcshane
as code owners
|
|
Spikhalskiy
approved these changes
Jan 25, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this pull request
Jan 25, 2022
Provide javadocs Make sure collections that are exposed by Options are immutable to avoid unintended modifications
Merged
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this pull request
Jan 25, 2022
Provide javadocs Make sure collections that are exposed by Options are immutable to avoid unintended modifications
Spikhalskiy
pushed a commit
that referenced
this pull request
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added
localActivityOptionsanddefaultLocalActivityOptionsfields and relevant setters/getters toWorkflowImplementationOptions,SyncWorkflowContext, andWorkflow, so that inWorkflow.newLocalActivityStub, any local activity options received from the workflow are merged with options in WorkflowImplementationOptions.Why?
Following existing WorkflowImplementationOptions.setActivityOptions, allow user to define local activity options for different types of activities instead of defining them in workflow code. This would be applied to
Workflow.newLocalActivityStub.Checklist
Closes Issue #975
How was this tested:
Duplicated existing tests for merging regular Activity Options for merging Local Activity Options.
DefaultActivityOptionsOnWorkflowNotSetTest.testDefaultLocalActivityOptionsNotSetTestis disabled for now as discussed with @SpikhalskiyAny docs updates needed?
Don't see any existing docs on
WorkflowImplementationOptionson docs.temporal.io