Polish #1001 #1003
Merged
Polish #1001 #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
Sushisource,
bergundy,
cretz,
mfateev and
mmcshane
as code owners
cretz
approved these changes
Jan 25, 2022
Provide javadocs Make sure collections that are exposed by Options are immutable to avoid unintended modifications
Spikhalskiy
force-pushed
the
issue-975-polish
branch
from
d3f43fe to
379f41f
Compare
Sushisource
reviewed
Jan 25, 2022
Sushisource
reviewed
Jan 25, 2022
Sushisource
reviewed
Jan 25, 2022
Sushisource
reviewed
Jan 25, 2022
Sushisource
approved these changes
Jan 25, 2022
Co-authored-by: Spencer Judge <sjudge@hey.com>
Spikhalskiy
force-pushed
the
issue-975-polish
branch
from
c09ad42 to
2b23921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Polish #1001
Provide javadocs
Rename
Workflowmethods for better clarityMake sure collections that are exposed by Options are immutable to avoid unintended modifications
Cleanup
This is mostly a refactoring and has no functional changes.