Added a newUntypedWorkflowStub method to WorkflowClient #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkoby
requested review from
mfateev,
Spikhalskiy,
Sushisource and
vitarb
as code owners
bergundy
reviewed
Oct 27, 2021
|
@bergundy see a discussion in the original ticket. The ask was to support creation based on workflowId + interface. After discussion with Max I realized that the interface is just not needed here. It's participating only in error messages/exceptions, but I untyped doesn't use neither String workflow type nor workflowInterface for anything useful. So the task transformed into exposing the simplest version for our user - get WorkflowStub by workflowId. |
|
Okay, I wasn't up-to-date with the discussion. |
Spikhalskiy
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added a newUntypedWorkflowStub method to WorkflowClient
Why?
Overload, to make stub creation more convenient
Closes Add an ability to create WorkflowStub from workflowInterface #761
How was this tested:
No logic to test