Skip to content

Added a newUntypedWorkflowStub method to WorkflowClient #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Added a newUntypedWorkflowStub method to WorkflowClient #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions temporal-sdk/src/main/java/io/temporal/client/WorkflowClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
import java.util.concurrent.CompletableFuture;

/**
* Client to the Temporal service used to start and query workflows by external processes. Also it
* Client to the Temporal service used to start and query workflows by external processes. Also, it
* supports creation of {@link ActivityCompletionClient} instances used to complete activities
* asynchronously. Do not create this object for each request, keep it for the duration of the
* process.
Expand All @@ -57,7 +57,7 @@
* There are two ways to start workflow execution: synchronously and asynchronously. Synchronous
* invocation starts a workflow and then waits for its completion. If the process that started the
* workflow crashes or stops waiting, the workflow continues executing. Because workflows are
* potentially long running, and crashes of clients happen, it is not very commonly found in
* potentially long-running, and crashes of clients happen, it is not very commonly found in
* production use. Asynchronous start initiates workflow execution and immediately returns to the
* caller. This is the most common way to start workflows in production code.
*
Expand Down Expand Up @@ -165,6 +165,16 @@ static WorkflowClient newInstance(WorkflowServiceStubs service, WorkflowClientOp
*/
<T> T newWorkflowStub(Class<T> workflowInterface, String workflowId, Optional<String> runId);

/**
* Creates workflow untyped client stub that can be used to start a single workflow execution. Use
* it to send signals or queries to a running workflow. Do not call methods annotated
* with @WorkflowMethod.
*
* @param workflowId Workflow id.
* @return Stub that can be used to start workflow and later to signal or query it.
*/
WorkflowStub newUntypedWorkflowStub(String workflowId);

/**
* Creates workflow untyped client stub that can be used to start a single workflow execution.
* After workflow is started it can be also used to send signals or queries to it. IMPORTANT! Stub
Expand Down
5 changes: 5 additions & 0 deletions temporal-sdk/src/main/java/io/temporal/internal/sync/WorkflowClientInternal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,11 @@ public <T> T newWorkflowStub(
return result;
}

@Override
public WorkflowStub newUntypedWorkflowStub(String workflowId) {
return newUntypedWorkflowStub(workflowId, Optional.empty(), Optional.empty());
}

@Override
@SuppressWarnings("deprecation")
public WorkflowStub newUntypedWorkflowStub(String workflowType, WorkflowOptions workflowOptions) {
Expand Down