Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http api port and async update flag #2314

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

Alex-Tideman
Copy link
Contributor

Description & motivation 💭

Add http-port to enable HTTP API for development.

Also add enableUpdateWorkflowExecutionAsyncAccepted to make sure all of Workflow Update features are enabled.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@Alex-Tideman Alex-Tideman requested a review from a team as a code owner September 9, 2024 13:52
@Alex-Tideman Alex-Tideman requested review from KATIETOLER, rossedfort and laurakwhit and removed request for a team September 9, 2024 13:52
Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 1:53pm

@Alex-Tideman Alex-Tideman changed the base branch from main to codefreeze-09.12.24 September 13, 2024 14:33
@Alex-Tideman Alex-Tideman merged commit 8e76540 into codefreeze-09.12.24 Sep 17, 2024
14 checks passed
@Alex-Tideman Alex-Tideman deleted the add-http-api branch September 17, 2024 19:23
Alex-Tideman added a commit that referenced this pull request Sep 24, 2024
* Accordion component updates (#2316)

* Fix styling for non-expandable Accordion

* Update padding on Card to match Accordion

* Add AccordionGroup

* Make ring inset on focus-within

* Fix imports and A11y warning

* Highlight active link in nav bar (#2324)

* Add active styling for nav item

* Add isActive check for nav links

* Account for if isActive is undefined

* Add http api port and async update flag (#2314)

* Show all possible failures for WorkflowTaskError (#2328)

* Use AccordionGroup to show all possible failures

* Dont use red text

* Move source to accordion

* Add pending task component and move into accordion group

* Fixes from Laura's review

* Bump express from 4.19.2 to 4.20.0 (#2323)

Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.20.0.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.19.2...4.20.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump vite from 5.0.13 to 5.2.14 (#2329)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.13 to 5.2.14.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.2.14/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.2.14/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update go to 1.22.6 (#2334)

* Update go to 1.23

* Use 1.22.6

* Remove work files

* Add go.work to gitignore

* Remove Start Workflow input preview, add error alert for invalid input (#2338)

* Remove preview codeblock, add error for invalid json

* Remove console

* Translate

* Update Label spacing (#2336)

* Update Combobox Label spacing to match Select

* Update Label spacing on Holocene components to match Select and Input

* Update Label spacing on custom components

---------

Co-authored-by: Alex Tideman <alex.tideman@temporal.io>

* Add env var to disable workflow count refresh (#2312)

* Event Type multiselect dropdown with All/None options (#2339)

* Move event type filters into a multiselect dropdown

* Set smaller width on mobile

* Add some padding to json view and don't include status filter

* Update snapshots

* Remove unused code

* Remove camelcase

* Fix typo

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant