Show all possible failures for WorkflowTaskError #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
laurakwhit
reviewed
Sep 16, 2024
laurakwhit
reviewed
Sep 17, 2024
laurakwhit
reviewed
Sep 17, 2024
laurakwhit
approved these changes
Sep 17, 2024
Alex-Tideman
added a commit
that referenced
this pull request
Sep 24, 2024
* Accordion component updates (#2316) * Fix styling for non-expandable Accordion * Update padding on Card to match Accordion * Add AccordionGroup * Make ring inset on focus-within * Fix imports and A11y warning * Highlight active link in nav bar (#2324) * Add active styling for nav item * Add isActive check for nav links * Account for if isActive is undefined * Add http api port and async update flag (#2314) * Show all possible failures for WorkflowTaskError (#2328) * Use AccordionGroup to show all possible failures * Dont use red text * Move source to accordion * Add pending task component and move into accordion group * Fixes from Laura's review * Bump express from 4.19.2 to 4.20.0 (#2323) Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.20.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.19.2...4.20.0) --- updated-dependencies: - dependency-name: express dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump vite from 5.0.13 to 5.2.14 (#2329) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.13 to 5.2.14. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.2.14/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.2.14/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update go to 1.22.6 (#2334) * Update go to 1.23 * Use 1.22.6 * Remove work files * Add go.work to gitignore * Remove Start Workflow input preview, add error alert for invalid input (#2338) * Remove preview codeblock, add error for invalid json * Remove console * Translate * Update Label spacing (#2336) * Update Combobox Label spacing to match Select * Update Label spacing on Holocene components to match Select and Input * Update Label spacing on custom components --------- Co-authored-by: Alex Tideman <alex.tideman@temporal.io> * Add env var to disable workflow count refresh (#2312) * Event Type multiselect dropdown with All/None options (#2339) * Move event type filters into a multiselect dropdown * Set smaller width on mobile * Add some padding to json view and don't include status filter * Update snapshots * Remove unused code * Remove camelcase * Fix typo --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Alex-Tideman
added a commit
that referenced
this pull request
Jan 9, 2025
* Accordion component updates (#2316) * Fix styling for non-expandable Accordion * Update padding on Card to match Accordion * Add AccordionGroup * Make ring inset on focus-within * Fix imports and A11y warning * Highlight active link in nav bar (#2324) * Add active styling for nav item * Add isActive check for nav links * Account for if isActive is undefined * Add workflow electron * Add http api port and async update flag (#2314) * Show all possible failures for WorkflowTaskError (#2328) * Use AccordionGroup to show all possible failures * Dont use red text * Move source to accordion * Add pending task component and move into accordion group * Fixes from Laura's review * Add border * WIP: filter * Bump express from 4.19.2 to 4.20.0 (#2323) Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.20.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.19.2...4.20.0) --- updated-dependencies: - dependency-name: express dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump vite from 5.0.13 to 5.2.14 (#2329) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.13 to 5.2.14. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.2.14/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.2.14/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix the go things * MVP of electron. Needs some performance tweaks and to add links to each node * Add icons, clean up * Remove commented out code * Update snapshots * Update go to 1.22.6 (#2334) * Update go to 1.23 * Use 1.22.6 * Remove work files * Add go.work to gitignore * Small UI fixes (#2345) * Remove unnecessary coerced Boolean * Pluralize Namespaces badge for Nexus endpoints * Fix action slot on Accordion component * Ignore a11y test on Accordion with action * 2.31.1 (#2346) Co-authored-by: Temporal Data (cicd) <commander-data@temporal.io> * Update version.go to v2.31.0 (#2347) * Use go 1.23.0 (#2348) * Use 1.23 (#2349) * Update go version to 1.23 in update ui-server (#2351) * Update go version to 1.23 in update ui-server * Use v4 * Add breadcrumbs for nodes * Add hover/click state with opacity * Add back child table * Fix overfetching issue * Fix icon type * WIP Family Tree * Get math right for tree positions * I did things but can't remember what * Remove electron stuff * Get rid of pane * Add side panel descriptions * Better styles and status color * Better side nav buttons. Better lines to dots. Need to fix the tree node expanding * Add link, needs a better place * Better styles on description, add links, fix opening nodes * Add table of info and link vis/sidenav with open/close * Add table * Better description * fix lines * Better isActive, isCurrent checks * isCurrent check * Make split 50/50 * Fix types * Better styles for active, better borders. * Refactor to include root, clean up styles, better basis widths * Add root child count on node tree * Make tree sticky on lg screens * Add CaN tree * Add schedule tree * Delete all unused tables * Delete breadcrumbs * Use justify-end to move links to far right * Fix sm screen layout * Make visual a little shorter at 240px, hide times if small screen * Add dash and min-w for end time, py-1 * Fix root node click and accessibility issues * Bump maxZoomOut for a lot of children * Add back old tables in case api not supported or if we wanna go labs mode route * Small style updates based on feedback, better responsive padding * Better count placement --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: temporal-cicd[bot] <138905749+temporal-cicd[bot]@users.noreply.github.com> Co-authored-by: Temporal Data (cicd) <commander-data@temporal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Currently we only show the first failure message and stack trace. It's possible to have deeply nested failures for some SDKS (Java, .NET). This updates our WorkflowTaskError alert to show all failures with message and stack trace to allow for better debugging.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?