Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for genesis initialization and export #223

Merged

Conversation

defihyung
Copy link
Contributor

@defihyung defihyung commented Apr 14, 2021

Description

This PR closes: #191 and it adds build and test-race jobs in github action workflow.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #223 (31d8f20) into develop (45cacb8) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #223      +/-   ##
===========================================
+ Coverage    82.84%   82.93%   +0.09%     
===========================================
  Files           20       20              
  Lines         2215     2215              
===========================================
+ Hits          1835     1837       +2     
+ Misses         209      208       -1     
+ Partials       171      170       -1     
Impacted Files Coverage Δ
x/liquidity/keeper/genesis.go 90.47% <0.00%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45cacb8...31d8f20. Read the comment docs.

@defihyung defihyung marked this pull request as ready for review April 20, 2021 05:04
@defihyung defihyung requested a review from dongsam April 20, 2021 05:05
@dongsam dongsam merged commit ee1aa8b into tendermint:develop Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Integration Tests for cli, genesis
2 participants