Skip to content

Conversation

seanpmorgan
Copy link
Member

@seanpmorgan seanpmorgan commented Apr 10, 2020

@seanpmorgan seanpmorgan added the backport r0.9 Will backport any PR merged with this label to the r0.9 branch label Apr 10, 2020
@gabrieldemarmiesse
Copy link
Member

Interested to know why the release call to build_and_release somehow picked up default values

It seems that in github actions, (maybe because it's in a build step), user input is not available, as such, in this line: https://github.com/tensorflow/addons/blob/master/configure.py#L174

answer is "" (empty string).

In google cloud, for some reason, (maybe the -t argument in the docker run), python thinks that user input is available, as such it doesn't return en EOF in this line: https://github.com/tensorflow/addons/blob/master/configure.py#L51 .

I believe that we shouldn't ask for user input and always use the environement variables or default values. I'll make a PR for that.

@gabrieldemarmiesse
Copy link
Member

I think this can be closed because it's superseded by #1634

@seanpmorgan seanpmorgan deleted the specify-cuda-env branch April 10, 2020 12:18
@seanpmorgan seanpmorgan restored the specify-cuda-env branch April 10, 2020 12:19
@seanpmorgan seanpmorgan deleted the specify-cuda-env branch April 15, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport r0.9 Will backport any PR merged with this label to the r0.9 branch cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants