Skip to content

Conversation

gabrieldemarmiesse
Copy link
Member

We shouldn't ask for user input, it's source of too many issues in the CI and hurts readability.

@gabrieldemarmiesse gabrieldemarmiesse changed the title Fix configure.py Fix configure.py (fixes the gpu build hanging). Apr 10, 2020
@gabrieldemarmiesse gabrieldemarmiesse added the backport r0.9 Will backport any PR merged with this label to the r0.9 branch label Apr 10, 2020
@googlebot

This comment has been minimized.

@seanpmorgan
Copy link
Member

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanpmorgan seanpmorgan merged commit 7820c82 into tensorflow:master Apr 10, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
* Fix configure.py
* Update README

Co-authored-by: Sean Morgan <seanmorgan91@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport r0.9 Will backport any PR merged with this label to the r0.9 branch cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants