Skip to content

Beautifier losses doc #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 17, 2020
Merged

Conversation

WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Aug 3, 2020

Description

Beautifier losses doc. Our doc is very messy 😢.

https://www.tensorflow.org/addons/api_docs/python/tfa/losses

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@boring-cyborg boring-cyborg bot added the losses label Aug 3, 2020
@WindQAQ WindQAQ requested a review from a team August 3, 2020 07:25
@bot-of-gabrieldemarmiesse

@SSaishruthi @wenmin-wu @AakashKumarNain @AndreasMadsen @lc0 @fsx950223 @RomainBrault @rahulunair

You are owners of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@WindQAQ WindQAQ changed the title Losses/beautifier doc Beautifier losses doc Aug 3, 2020
@bhack
Copy link
Contributor

bhack commented Aug 3, 2020

Did you use any tools?

@WindQAQ
Copy link
Member Author

WindQAQ commented Aug 3, 2020

Did you use any tools?

No, I just use my eyes and build doc locally to check the result.

https://github.com/tensorflow/addons/tree/master/docs

@lc0
Copy link
Contributor

lc0 commented Aug 3, 2020

Thanks for making the docs more beautiful! 🥳

@AakashKumarNain
Copy link
Member

Thanks for doing this @WindQAQ This is really good

@WindQAQ WindQAQ requested a review from a team August 17, 2020 05:49
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @WindQAQ !

@seanpmorgan seanpmorgan merged commit e62add5 into tensorflow:master Aug 17, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants