This repository was archived by the owner on Apr 23, 2025. It is now read-only.
Add alternative protocols supported by TF and SIG-Networking #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bairen Yi <yibairen.byron@bytedance.com>
karmel
reviewed
Jul 9, 2019
| message='protocol should be grpc or grpc+verbs') | ||
| lambda protocol: protocol in ( | ||
| None, "grpc", "grpc+verbs", "grpc+gdr", "grpc+mpi", "grpc+seastar"), | ||
| message='protocol should be either grpc, grpc+verbs, grpc+gdr, grpc+mpi, or grpc+seastar') |
There was a problem hiding this comment.
Do we have to do anything to actually ensure that these work? What does it mean to pass these through without tests or actual code to handle the changes?
There was a problem hiding this comment.
Right now we do not have protocol registration mechanism in Python. I will submit a separate PR in TF core to expose available protocol information. Ping @annarev to confirm.
|
I'm going to go ahead and close this PR, because it seems to have stalled. If you're still interested in pursing this (and responding to my comments), please feel free to reopen! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now TF 1.x supports the following networking protocols:
And once we reach 2.0, these protocols will be supported by SIG-Networking.