Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

Add alternative protocols supported by TF and SIG-Networking #36

Closed
wants to merge 1 commit into from
Closed

Add alternative protocols supported by TF and SIG-Networking #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tensorflow_estimator/python/estimator/run_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,9 @@ def _validate_delay(delay):
' one argument "op".')

_validate('protocol',
lambda protocol: protocol in (None, "grpc", "grpc+verbs"),
message='protocol should be grpc or grpc+verbs')
lambda protocol: protocol in (
None, "grpc", "grpc+verbs", "grpc+gdr", "grpc+mpi", "grpc+seastar"),
message='protocol should be either grpc, grpc+verbs, grpc+gdr, grpc+mpi, or grpc+seastar')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to do anything to actually ensure that these work? What does it mean to pass these through without tests or actual code to handle the changes?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now we do not have protocol registration mechanism in Python. I will submit a separate PR in TF core to expose available protocol information. Ping @annarev to confirm.



def get_default_session_config():
Expand Down