Skip to content

Conversation

@zjj2wry
Copy link
Member

@zjj2wry zjj2wry commented Dec 14, 2017

I1214 14:57:52.480730   20446 main.go:83] No controller_config_file provided; using empty config.
I1214 14:57:52.481311   20446 main.go:113] tf_operator Version: 0.3.0+git
I1214 14:57:52.481332   20446 main.go:114] Git SHA: ba0bdfb
I1214 14:57:52.481338   20446 main.go:115] Go Version: go1.9.2
I1214 14:57:52.481343   20446 main.go:116] Go OS/Arch: darwin/amd64

This change is Reviewable

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile Outdated
@@ -0,0 +1,28 @@
# Current version of the project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Makefile isn't invoked by our CI/CD test infrastructure so the changes wouldn't actually be picked up by the released artifacts.

The current approach is to use Python scripts to invoke the build steps (bazel has been discussed as a possible solution).

This is the Python function that invokes go build in our continuous tests
https://github.com/tensorflow/k8s/blob/master/py/release.py#L138

Our continuous release process is just a cron job that invokes that script
https://github.com/tensorflow/k8s/blob/master/release/releaser.yaml

So I think you just want to update the go command line here
https://github.com/tensorflow/k8s/blob/master/py/release.py#L138

And then the changes would be picked up.

@zjj2wry
Copy link
Member Author

zjj2wry commented Dec 17, 2017

@jlewi thanks you very much, will do it

@jlewi
Copy link
Contributor

jlewi commented Dec 25, 2017

@zjj2wry Let me know when this is ready for another look.

@coveralls
Copy link

coveralls commented Dec 26, 2017

Coverage Status

Coverage remained the same at 37.782% when pulling 97fc9bf on zjj2wry:makefile into 60b8f7a on tensorflow:master.

@zjj2wry
Copy link
Member Author

zjj2wry commented Dec 26, 2017

@jlewi sorry for delay, this ready, ptal

Copy link
Contributor

@jlewi jlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlewi jlewi merged commit 439b99f into kubeflow:master Dec 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants