-
Notifications
You must be signed in to change notification settings - Fork 837
feature(lint): use prettier and lint-staged for frontend javascript code #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @jimexist. Thanks for your PR. I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
/ok-to-test |
|
this PR needs @wbuchwalter 's attention, happy holiday by the way. |
|
/retest |
|
Test failed because it wasn't able to create the test cluster because we ran out of quota This is #80 (E2E tests leaking clusters) |
|
/test all |
|
@jlewi thanks. still need @wbuchwalter's LGTM if possible |
|
since there's another PR that's depending on this and it is more of a dramatic change so i'll suggest merging this and there's always room to do reset. |
See #244 for a consistent auto-reformat of current code
This change is