Skip to content

Conversation

@jimexist
Copy link
Member

@jimexist jimexist commented Dec 24, 2017

merge after #243

a follow-up PR will be made to fix all eslint errors (for now they stayed put).


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @jimexist. Thanks for your PR.

I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jimexist jimexist changed the title Apply prettier to format frontend src/ code feat(lint): apply prettier to format frontend src/ code Dec 24, 2017
@coveralls
Copy link

coveralls commented Dec 24, 2017

Coverage Status

Coverage remained the same at 37.782% when pulling 247e0fc on Jimexist:apply-prettier into bcfc14f on tensorflow:master.

@jimexist
Copy link
Member Author

jimexist commented Dec 24, 2017

There are so many of them, I plan to fix them in next patch. Note that most of them are just missing prop-types, so my motivation for adding this is to try to enforce people to add prop-types upon submission.

λ ~/go/src/github.com/tensorflow/k8s/dashboard/frontend/ apply-prettier yarn eslint src
yarn run v1.3.2
$ /Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/node_modules/.bin/eslint src

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/App.js
  44:13  error  'props' is defined but never used  no-unused-vars

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/App.test.js
  5:1  error  'it' is not defined  no-undef

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/AppBar.js
  21:7   error  Missing "key" prop for element in array                     react/jsx-key
  24:18  error  '_' is defined but never used                               no-unused-vars
  26:7   error  Missing "key" prop for element in array                     react/jsx-key
  29:18  error  '_' is defined but never used                               no-unused-vars
  37:20  error  'location' is missing in props validation                   react/prop-types
  37:29  error  'location.pathname' is missing in props validation          react/prop-types
  45:22  error  '_' is defined but never used                               no-unused-vars
  63:49  error  HTML entities must be escaped                               react/no-unescaped-entities
  63:54  error  HTML entities must be escaped                               react/no-unescaped-entities
  63:69  error  HTML entities must be escaped                               react/no-unescaped-entities
  63:74  error  HTML entities must be escaped                               react/no-unescaped-entities
  80:45  error  'location.pathname.replace' is missing in props validation  react/prop-types
  85:33  error  Unexpected console statement                                no-console

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/CreateJob.js
  309:13  error  '_' is defined but never used                    no-unused-vars
  309:29  error  'history' is missing in props validation         react/prop-types
  309:37  error  'history.push' is missing in props validation    react/prop-types
  310:14  error  Unexpected console statement                     no-console
  314:24  error  'history.goBack' is missing in props validation  react/prop-types

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/CreateTensorBoard.js
  72:16  error  'setTensorBoardSpec' is missing in props validation  react/prop-types

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/EnvVar.js
  67:16  error  'setEnvVar' is missing in props validation     react/prop-types
  67:37  error  'id' is missing in props validation            react/prop-types
  71:16  error  'deleteEnvVar' is missing in props validation  react/prop-types

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/EnvVarCreator.js
  28:20  error  '_' is defined but never used                no-unused-vars
  58:16  error  'setEnvVars' is missing in props validation  react/prop-types

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/Home.js
  21:17  error  '_' is defined but never used  no-unused-vars
  29:14  error  Unexpected console statement   no-console

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/InfoEntry.js
  20:47  error  'name' is missing in props validation    react/prop-types
  22:23  error  'linkTo' is missing in props validation  react/prop-types
  24:27  error  'value' is missing in props validation   react/prop-types

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/Job.js
  63:16  error  Unexpected console statement  no-console

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/JobDetail.js
  5:22  error  'tfjob' is missing in props validation  react/prop-types

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/JobList.js
  9:20  error  'jobs' is missing in props validation  react/prop-types

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/JobSummary.js
  5:23  error  'job' is missing in props validation  react/prop-types

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/PodList.js
  27:5   error  Missing "key" prop for element in array  react/jsx-key
  31:16  error  '_' is defined but never used            no-unused-vars
  36:27  error  'pods' is missing in props validation    react/prop-types
  56:45  error  '_' is defined but never used            no-unused-vars
  89:14  error  'b' is defined but never used            no-unused-vars
  89:19  error  Unexpected console statement             no-console

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/ReplicaSpec.js
  6:24  error  'spec' is missing in props validation    react/prop-types
  6:30  error  'status' is missing in props validation  react/prop-types
  6:38  error  'pods' is missing in props validation    react/prop-types

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/RequiredTextField.js
  10:23  error  'value' is missing in props validation     react/prop-types
  21:28  error  'name' is missing in props validation      react/prop-types
  34:16  error  'onChange' is missing in props validation  react/prop-types

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/TensorBoard.js
  5:24  error  'service' is missing in props validation  react/prop-types

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/Volume.js
  144:9   error  Unexpected console statement                    no-console
  163:16  error  'setVolumeSpec' is missing in props validation  react/prop-types
  163:41  error  'id' is missing in props validation             react/prop-types
  187:16  error  'deleteVolume' is missing in props validation   react/prop-types

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/components/VolumeCreator.js
  28:20  error  '_' is defined but never used                    no-unused-vars
  63:16  error  'setVolumesSpec' is missing in props validation  react/prop-types

/Users/jiayu/go/src/github.com/tensorflow/k8s/dashboard/frontend/src/registerServiceWorker.js
  22:7   error  'process' is not defined      no-undef
  24:31  error  'process' is not defined      no-undef
  33:24  error  'process' is not defined      no-undef
  59:15  error  Unexpected console statement  no-console
  64:15  error  Unexpected console statement  no-console
  71:7   error  Unexpected console statement  no-console
  96:7   error  Unexpected console statement  no-console

✖ 61 problems (61 errors, 0 warnings)

@zjj2wry
Copy link
Member

zjj2wry commented Dec 25, 2017

/ok-to-test

@jlewi
Copy link
Contributor

jlewi commented Dec 26, 2017

@jimexist Change LGTM. Looks like the files are out of date though and need to be synced.

@coveralls
Copy link

coveralls commented Dec 27, 2017

Coverage Status

Coverage remained the same at 37.782% when pulling edf65a2 on Jimexist:apply-prettier into a704246 on tensorflow:master.

@coveralls
Copy link

coveralls commented Dec 27, 2017

Coverage Status

Coverage increased (+0.1%) to 37.915% when pulling edf65a2 on Jimexist:apply-prettier into a704246 on tensorflow:master.

@coveralls
Copy link

coveralls commented Dec 27, 2017

Coverage Status

Coverage remained the same at 37.782% when pulling 011e8bc on Jimexist:apply-prettier into a704246 on tensorflow:master.

@jlewi jlewi merged commit e98b10c into kubeflow:master Dec 27, 2017
@jimexist jimexist deleted the apply-prettier branch December 28, 2017 02:24
sutaakar pushed a commit to sutaakar/training-operator that referenced this pull request Mar 25, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants