Skip to content

refactor code and format imported package #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2017
Merged

refactor code and format imported package #245

merged 2 commits into from
Dec 27, 2017

Conversation

@zjj2wry
Copy link
Member

@zjj2wry zjj2wry commented Dec 26, 2017 •
edited by jlewi
Loading

This change is Reviewable

zjj2wry
zjj2wry commented Dec 26, 2017
View reviewed changes
cmd/tf_operator/main.go
}

// TODO: replace with to client-go once leader election pacakge is imported
// see https://github.com/kubernetes/client-go/issues/28
Copy link
Member Author

@zjj2wry zjj2wry Dec 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this moved to client-go, so i remove it

@coveralls
Copy link

coveralls commented Dec 26, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 37.915% when pulling e99df4b on zjj2wry:ref_fmt into 60b8f7a on tensorflow:master.

@zjj2wry
Copy link
Member Author

zjj2wry commented Dec 26, 2017

/test tf-k8s-presubmit

jimexist
jimexist reviewed Dec 26, 2017
View reviewed changes
version/version.go Outdated
"os"
"runtime"

"github.com/qiniu/log"
Copy link
Member

@jimexist jimexist Dec 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong

@coveralls
Copy link

coveralls commented Dec 26, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 37.782% when pulling 77bbb04 on zjj2wry:ref_fmt into 60b8f7a on tensorflow:master.

@jimexist
Copy link
Member

jimexist commented Dec 27, 2017

nit: rafactor > refactor

@zjj2wry zjj2wry changed the title rafactor code and format imported package refactor code and format imported package Dec 27, 2017
@zjj2wry
Copy link
Member Author

zjj2wry commented Dec 27, 2017

@jimexist thanks, ptal

@zjj2wry
Copy link
Member Author

zjj2wry commented Dec 27, 2017

@jlewi @jimexist minor changed, ptal

@jlewi jlewi merged commit 2634032 into kubeflow:master Dec 27, 2017
sutaakar pushed a commit to sutaakar/training-operator that referenced this pull request Mar 25, 2025
@konflux-internal-p02
Update Konflux references to b9cb1e1 (kubeflow#245)
2ca44c9 
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jimexist jimexist jimexist left review comments

@jlewi jlewi jlewi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zjj2wry @coveralls @jimexist @jlewi