Fix leaking of clusters in E2E tests #80 #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* setup_cluster needs to push the cluster name so that it is available to the teardown step before we try to setup the cluster so that the name is available even if setup_cluster fails. * setup_cluster also needs to handle the case where setup_cluster might already have been attempted; in which case we should reuse that cluster.
Contributor
Author
|
/cc @zjj2wry @jimexist @gaocegege @ScorpioCPH Can one of you review this please? (I think most of the folks in the US are out this week). |
Member
|
Sure, add related issue: #80 |
ScorpioCPH
approved these changes
Dec 27, 2017
Member
ScorpioCPH
left a comment
ScorpioCPH
left a comment
There was a problem hiding this comment.
LGTM, sorry i don't have GKE env to run this script, so just review the code logic :)
Contributor
Author
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup_cluster needs to push the cluster name so that it is available to
the teardown step before we try to setup the cluster so that the name
is available even if setup_cluster fails.
setup_cluster also needs to handle the case where setup_cluster might
already have been attempted; in which case we should reuse that cluster.
Fix E2E tests leaking GKE clusters #80
This change is