-
Notifications
You must be signed in to change notification settings - Fork 837
apply goimports -w to generated files #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @jimexist. Thanks for your PR. I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
| "LineLength": 240, | ||
| "Exclude": ["comment or be unexported", "comment on exported"], | ||
| "Exclude": [ | ||
| "redundant return statement", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think redundant return is to because that's a lint issue in one of the auto copy files. Instead of excluding this warning for all files can we just exclude the deepcopy file from lint checks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok i will try to do a follow up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I went ahead and submit this because it fixes the travis build
|
Going to merge this so we fix the build. |
fixes #256
No good way to tell whether a file was generated. a better way is to ensure that all files and newly submitted ones are
goimported. also from now on I think it is better to enforce that even generated code are pre-goimported.I didn't fix all the lint warnings because I am afraid of changing any code other than using
goimport. I suggest that the original author do the changes instead.This change is