-
Notifications
You must be signed in to change notification settings - Fork 837
Add proposed directories layout #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @ScorpioCPH. Thanks for your PR. I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
mv |
|
Why is py under hack? It contains a bunch of scripts that are critical to our test infrastructure. So that one could do I don't think the tf-job-operator chart belongs under examples; its not an example its the actual way we recommend deploying the tf-job-operator (although I want to switch to ksonnet). Does it make more sense to leave the charts directory and move it into that? |
|
@jlewi Hi, I follow up Kubernetes style :)
How about put
Move them into |
|
Sorry for the delay
Can we leave the py directory as is for now? The modules aren't necessarily test specific so they might not belong in testing. For example, there's a very crude python client library for working with tfjobs. This is useful outside of testing; e.g. for managing TfJobs from Jupyter notebooks. So eventually we might want to turn this into a pip package that we officially release maintain. So I think the direction we are headed is organizing all py code under "/py" such that anything in "py" is a top level package.
./tf-job-operator-chart isn't the actual release artifact. The released artifact is the result of substituting in values to pin things like images to a particular release. So I don't know that it makes sense to put in build/release. That said; I'd like to get rid of the helm packages in favor of ksonnet (#239). So I'd suggest leaving it where is for now since we'll eventually delete it so moving it is just churn. |
|
I'd also be ok with putting the tf-job-operator chart under hack or /legacy or /deprecated to indicate its something we want to get rid of. |
|
The python code is uncoupled with the go code so could we place the python code into another repo? |
LGTM :) |
| $ tree -d -I 'vendor|bin|.git' | ||
| ├── build | ||
| │ ├── images | ||
| │ │ └── tf_operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is in the images directory? Dockerfiles for images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
developer_guide.md
Outdated
| │ └── tf_sample | ||
| │ └── tf_sample | ||
| ├── hack | ||
| │ └── py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion please make py toplevel directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
| ├── examples | ||
| │ ├── charts | ||
| │ │ ├── tensorboard | ||
| │ │ └── tf-job-operator-chart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per conversation tf-job-operator-chart should not be under examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
0dcf6e6 to
b104cf9
Compare
|
Approved |
As proposed here: #261 This PR move folders around to match new directories layout with nothing changed.
@jlewi @gaocegege @zjj2wry @wackxu @DjangoPeng This PR proposed new directories layout as shown below:
PTAL and leave your comments about this change, and after discussion i will send a PR to do this directories refactor. Thanks!
This change is