Skip to content

Conversation

@jlewi
Copy link
Contributor

@jlewi jlewi commented Jan 2, 2018

  • Fix a typo in a comment.

  • Remove the function run_lint in prow.py; this function is no longer used
    to run lint checks; there is a python script for that now.


This change is Reviewable

* Fix a typo in a comment.

* Remove the function run_lint in prow.py; this function is no longer used
  to run lint checks; there is a python script for that now.
@jlewi jlewi requested a review from zjj2wry January 2, 2018 23:53
@coveralls
Copy link

coveralls commented Jan 3, 2018

Coverage Status

Coverage increased (+0.08%) to 28.601% when pulling a0f0596 on jlewi:typo_fix into ed7cae7 on tensorflow:master.

Copy link
Member

@zjj2wry zjj2wry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zjj2wry
Copy link
Member

zjj2wry commented Jan 3, 2018

The command "gometalinter --config=linter_config.json ./pkg/..." exited with 1.

@coveralls
Copy link

coveralls commented Jan 3, 2018

Coverage Status

Coverage remained the same at 28.458% when pulling cc0ecbb on jlewi:typo_fix into 519b0ac on tensorflow:master.

@jlewi
Copy link
Contributor Author

jlewi commented Jan 3, 2018

The travis build was fixed by #257.

@jlewi jlewi merged commit daf42d8 into kubeflow:master Jan 3, 2018
sutaakar pushed a commit to sutaakar/training-operator that referenced this pull request Mar 25, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants