Skip to content

Conversation

@haitch
Copy link
Contributor

@haitch haitch commented Jan 11, 2018

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @haitch. Thanks for your PR.

I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaocegege
Copy link
Member

Hi @haitch

Actually we should use controller-config-file, please see #279

If you want to solve the problem, I suggest to replace controller_config_file with controller-config-file in the code.

@coveralls
Copy link

coveralls commented Jan 11, 2018

Coverage Status

Coverage remained the same at 30.624% when pulling a7971d0 on haitch:master into 7ddafd5 on tensorflow:master.

@jlewi
Copy link
Contributor

jlewi commented Jan 12, 2018

Fixed by #295 which updated the flag.

@jlewi jlewi closed this Jan 12, 2018
sutaakar pushed a commit to sutaakar/training-operator that referenced this pull request Mar 25, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants