feat(dashboard): Namespace handling #338
Conversation
|
Hi @wbuchwalter. Thanks for your PR. I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| import { getTfJobListService } from "../services"; | ||
| import { getTfJobListService, getNamespaces } from "../services"; | ||
|
|
||
| const all_namespaces_key = "All namespaces"; |
There was a problem hiding this comment.
Yep, sorry, had a Python moment apparently...
| func (apiHandler *APIHandler) handleGetNamespaces(request *restful.Request, response *restful.Response) { | ||
| l, err := apiHandler.cManager.ClientSet.CoreV1().Namespaces().List(metav1.ListOptions{}) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
maybe also need to handle this?
|
/ok-to-test |
| <AppBar /> | ||
| <div id="main" style={this.styles.mainStyle}> | ||
| <div style={this.styles.list}> | ||
| <div> |
|
/retest |
|
@jlewi Could you review this? Need approval before merging. |
|
LGTM. I don't have write access yet, but just FYI |
5 participants
Fix #334 & #324.
Adds a selector to choose a namespace in which we should list the TFJobs.
By default we look into every namespace.
Also handles namespaces correctly at creation.
If a job is created in a new (non-existant) namespace, the namespace will be created before-hand.
This change is