Skip to content

Conversation

@gaocegege
Copy link
Member

@gaocegege gaocegege commented Feb 1, 2018

Close #266

Signed-off-by: Ce Gao gaoce@caicloud.io


This change is Reviewable

Close #266

Signed-off-by: Ce Gao <gaoce@caicloud.io>
@k8s-ci-robot
Copy link

Hi @gaocegege. Thanks for your PR.

I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Feb 1, 2018

Coverage Status

Coverage remained the same at 31.746% when pulling 9e8825c on gaocegege:copyright into 330eb92 on tensorflow:master.

@ewilderj
Copy link

ewilderj commented Feb 1, 2018

Please revise to Copyright The Kubeflow Authors, vs Google.

@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2018

I apologize for giving incorrect and misleading information about the author.

@gaocegege
Copy link
Member Author

@ewilderj I filed the PR before I saw the comment 😄 And it could be frozen until we have a conclusion about the copyright owner.

@jlewi Never mind 😃

@ewilderj
Copy link

ewilderj commented Feb 2, 2018

@gaocegege thanks for your work on this!

Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
Copy link
Member Author

I have updated the owner to The Kubeflow Authors, PTAL

Copy link
Member

@ScorpioCPH ScorpioCPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work!
For Copyright comments, I prefer to /* */ style rather than //.

@gaocegege
Copy link
Member Author

@jlewi jlewi merged commit 4676740 into kubeflow:master Feb 2, 2018
@gaocegege gaocegege deleted the copyright branch March 6, 2018 01:49
sutaakar pushed a commit to sutaakar/training-operator that referenced this pull request Jul 22, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants