-
Notifications
You must be signed in to change notification settings - Fork 837
Add argo workflow status link #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reasons for change: - Would like a link directly from a PR to the corresponding argo workflow Changes made: - Adds steps to the workflow for setting github status to pending, success, or failure - Adds github_status.py for sending status update
|
Hi @jose5918. Thanks for your PR. I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jlewi Does this |
gaocegege
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I am not sure if we should place the code in this repo.
| # Repo org and name can be set via environment variables when running | ||
| # on PROW. But we choose sensible defaults so that we can run locally without | ||
| # setting defaults. | ||
| REPO_ORG = os.getenv("REPO_OWNER", "tensorflow") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could add a todo since we are migrating to kubeflow/tf-operator.
|
@gaocegege Yeah, I can move most if not everything to kubeflow/testing, but I'm not where people want it. It might be easier to do an initial test as is in this repo just to see if it works though |
|
Generic code should be in kubeflow/testing. Is there a way to avoid having to add the steps to each workflow? Can we move the logic into run_e2e_workflow.py? |
|
@jlewi Sure, I'll do that. |
|
Closing in favor of kubeflow/testing#17 |
Reasons for change:
Changes made:
This change is