Skip to content

Conversation

@jose5918
Copy link
Contributor

@jose5918 jose5918 commented Feb 7, 2018

Reasons for change:

  • Would like a link directly from a PR to the corresponding argo workflow to make debugging easier

Changes made:

  • Adds steps to the workflow for setting github status to pending, success, or failure
  • Adds github_status.py for sending status update

This change is Reviewable

Reasons for change:
- Would like a link directly from a PR to the corresponding argo workflow

Changes made:
- Adds steps to the workflow for setting github status to pending, success, or failure
- Adds github_status.py for sending status update
@k8s-ci-robot
Copy link

Hi @jose5918. Thanks for your PR.

I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Feb 7, 2018

Coverage Status

Coverage remained the same at 31.746% when pulling fadc8ba on jose5918:argo-status into 0de450f on tensorflow:master.

@jose5918
Copy link
Contributor Author

jose5918 commented Feb 7, 2018

@jlewi Does this GIT_TOKEN have the ability to post status? I just used what was available when doing this

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I am not sure if we should place the code in this repo.

# Repo org and name can be set via environment variables when running
# on PROW. But we choose sensible defaults so that we can run locally without
# setting defaults.
REPO_ORG = os.getenv("REPO_OWNER", "tensorflow")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add a todo since we are migrating to kubeflow/tf-operator.

@jose5918
Copy link
Contributor Author

jose5918 commented Feb 8, 2018

@gaocegege Yeah, I can move most if not everything to kubeflow/testing, but I'm not where people want it. It might be easier to do an initial test as is in this repo just to see if it works though

@jlewi
Copy link
Contributor

jlewi commented Feb 8, 2018

Generic code should be in kubeflow/testing.

Is there a way to avoid having to add the steps to each workflow? Can we move the logic into run_e2e_workflow.py?

@jose5918
Copy link
Contributor Author

jose5918 commented Feb 8, 2018

@jlewi Sure, I'll do that.

@jose5918
Copy link
Contributor Author

jose5918 commented Feb 9, 2018

Closing in favor of kubeflow/testing#17

@jose5918 jose5918 closed this Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants