Skip to content

Add clustering overview document and Jupyter notebooks to _book.yaml #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2020
Merged

Add clustering overview document and Jupyter notebooks to _book.yaml #473

merged 1 commit into from
Aug 6, 2020

Conversation

arovir01
Copy link
Contributor

@arovir01 arovir01 commented Jul 22, 2020 •
edited
Loading

This PR adds the relevant weight clustering documentation to _book.yaml in order to make them visible on the TFMOT site.

Note: This depends on #330

@googlebot googlebot added the cla: yes PR contributor has signed CLA label Jul 22, 2020
@arovir01 arovir01 force-pushed the toupstream/clustering_book_yaml branch from 125ddfd to 769939f Compare July 22, 2020 11:00
@arovir01
Copy link
Contributor Author

@akarmi Please review.

alanchiao
alanchiao reviewed Jul 24, 2020
View reviewed changes
@arovir01 arovir01 force-pushed the toupstream/clustering_book_yaml branch from 769939f to 571c756 Compare July 28, 2020 12:44
@ashwinmurthy ashwinmurthy self-assigned this Jul 31, 2020
@ashwinmurthy ashwinmurthy added the ready to pull Working to get PR submitted to internal repository, after which merging to Github happens. label Jul 31, 2020
@alanchiao alanchiao removed the ready to pull Working to get PR submitted to internal repository, after which merging to Github happens. label Jul 31, 2020
@alanchiao
Copy link

alanchiao commented Jul 31, 2020 •
edited
Loading

@ashwinmurthy : thanks for being proactive here. We're holding off merging this until we get closer to the weight clustering announcement.

In light of situations like this, I was planning to update the rotation process so that the rotation is not responsible for applying the "ready to pull label". Instead, the reviewer is. Afterwards, the rotation will get the PR merged.

@ashwinmurthy
Copy link

@alanchiao thanks for the note! Any suggestion on what I should do on this then, remove the ready to pull label or just leave it as is?

@alanchiao
Copy link

Yes removing the "ready to pull" label is sufficient. I've done it.

@alanchiao
Copy link

It's a bit early still relative to Monday, but will merge this now since it takes a day to update tensorflow.org and want to leave time in case anything looks off.

@alanchiao alanchiao added the ready to pull Working to get PR submitted to internal repository, after which merging to Github happens. label Aug 6, 2020
@copybara-service copybara-service bot merged commit a0ceed8 into tensorflow:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@alanchiao alanchiao alanchiao approved these changes

@akarmi akarmi akarmi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ashwinmurthy ashwinmurthy

Labels
cla: yes PR contributor has signed CLA ready to pull Working to get PR submitted to internal repository, after which merging to Github happens.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arovir01 @alanchiao @ashwinmurthy @akarmi @googlebot