from six.moves import xrange (en masse) #3206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
cclauss
requested review from
bogatyy,
bousmalis,
calberti,
cshallue,
derekjchow,
hellojas,
jch1,
joel-shor,
lukaszkaiser,
markomernick,
nmjohn,
ofirnachum,
panyx0718,
sguada and
theraysmith
as code owners
|
The xrange is imported but not used? Would this cause lint issue? |
|
In which file is xrange() not used? |
|
I was looking at the diff. They import xrange. But I don't see xrange is used in the diff. I assume they weren't used before, otherwise there would be exceptions before this change. |
|
Each file contains at least one call to xrange(). You can test this via: |
|
Oh, I see. you changed the existing xrange to use the six xrange |
panyx0718
approved these changes
Jan 20, 2018
cshallue
approved these changes
Jan 22, 2018
|
Looks good @cclauss. Thanks! |
This was referenced Jan 22, 2018
Adrrei
pushed a commit
to Adrrei/models
that referenced
this pull request
Dec 16, 2018
…-xrange from six.moves import xrange (en masse)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nealwu As requested at #3103 (comment)
For all files that use the Python 2-only builtin function xrange(), add the line from six.moves import xrange for compatibility with Python 3.