-
Notifications
You must be signed in to change notification settings - Fork 45.4k
Fix Python 3 Syntax Errors (en masse) #3229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this! Two comments below.
tgt_set = set(target) | ||
if print_out: | ||
print "target: ", tgt_prog | ||
print("target: ", tgt_prog) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs from __future__ import print_function
above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Done.
print "--------" | ||
print("dev set accuracy after ", i, " : ", gc / num_examples) | ||
print(num_examples, len(data)) | ||
print("--------") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here--we need from __future__ import print_function
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Fix Python 3 Syntax Errors (en masse)
Like the other en masse PRs, #3206 and #3220 but this one focuses on fixing Python 3 syntax errors. Each line modified in this PR is one of the following:
@nealwu