Skip to content

Use reduce_mean instead of Average Pooling in Resnet #3675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 20, 2018
Merged

Use reduce_mean instead of Average Pooling in Resnet #3675

merged 10 commits into from
Mar 20, 2018

Conversation

karmel
Copy link
Contributor

@karmel karmel commented Mar 20, 2018

This gives us an extra 0.5% - 1.5% examples/second, depending on the environment, and should not in theory change the model architecture itself. Final accuracy for ImageNet was unchanged at 76.38%, CIFAR-10 92.5%.

CC @bignamehyp @reedwm

@karmel karmel requested review from nealwu and robieta March 20, 2018 21:40
@karmel karmel requested a review from k-w-w as a code owner March 20, 2018 21:40
@k-w-w
Copy link
Contributor

k-w-w commented Mar 20, 2018

Nice!
Can you rename final_avg_pool to final_reduce_mean in imagenet_test.py as well?

@karmel
Copy link
Contributor Author

karmel commented Mar 20, 2018

Nice catch. Tests fixed. (Linting being fixed in #3676 .)

k-w-w
k-w-w approved these changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@k-w-w k-w-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@karmel karmel merged commit d5663b3 into master Mar 20, 2018
@karmel karmel deleted the fix/perf-tune-model branch March 20, 2018 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nealwu nealwu Awaiting requested review from nealwu

@robieta robieta Awaiting requested review from robieta

1 more reviewer

@k-w-w k-w-w k-w-w approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karmel @k-w-w @googlebot