Skip to content

Conversation

karmel
Copy link
Contributor

@karmel karmel commented Mar 20, 2018

Not sure why, but Kokoro's pylint is complaining about a few method names that were okay locally. Fixing the rcfile here.

@karmel karmel requested review from k-w-w and nealwu as code owners March 20, 2018 22:35
@karmel karmel requested review from qlzh727 and removed request for nealwu March 20, 2018 22:35
@qlzh727
Copy link
Member

qlzh727 commented Mar 20, 2018

Can u point me to the kokoro run that complains about the lint error?

Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the regex, seems that "setUp" and "tearDown" should fail, but I am not sure why it passed locally.

I guess this is fine for the moment.

@karmel karmel merged commit bea947d into master Mar 21, 2018
@karmel karmel deleted the fix/linting branch March 21, 2018 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants