Fix the testing script exit code for python test. #3858
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmel
approved these changes
Apr 3, 2018
| local PY_BINARY=$(which python2) | ||
| return $(py_test "${PY_BINARY}") | ||
| py_test "$PY_BINARY" | ||
| return $? |
There was a problem hiding this comment.
Can you add comments describing what this means, and why it is necessary, so that we avoid the next person "helpfully" removing the extra line?
There was a problem hiding this comment.
sure. Will do in a separate PR.
omegafragger
pushed a commit
to omegafragger/models
that referenced
this pull request
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.