Skip to content

Fix the testing script exit code for python test. #3858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Fix the testing script exit code for python test. #3858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions official/utils/testing/scripts/presubmit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,14 @@ py_test() {

py2_test() {
local PY_BINARY=$(which python2)
return $(py_test "${PY_BINARY}")
py_test "$PY_BINARY"
return $?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add comments describing what this means, and why it is necessary, so that we avoid the next person "helpfully" removing the extra line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. Will do in a separate PR.

}

py3_test() {
local PY_BINARY=$(which python3)
return $(py_test "${PY_BINARY}")
py_test "$PY_BINARY"
return $?
}

test_result=0
Expand Down