Skip to content

Conversation

qlzh727
Copy link
Member

@qlzh727 qlzh727 commented Apr 27, 2018

  1. trainning hooks and train/eval function does not need to be
    declared for every training cycle.
  2. change to use tf.logging.info instead of print
  3. Show the current index and total count of training cycle, which
    give user some hint about where they are in the whole process.

1. trainning hooks and train/eval function does not need to be
declared several times.
2. change to use tf.logging.info instead of print
3. Show the current index and total count of training cycle, which
give user some hint about where they are in the whole process.
@qlzh727 qlzh727 requested review from a team and karmel as code owners April 27, 2018 23:30
@qlzh727 qlzh727 requested a review from robieta April 27, 2018 23:30
Copy link
Contributor

@robieta robieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, much cleaner.

@qlzh727 qlzh727 merged commit 7f351c6 into tensorflow:master Apr 27, 2018
xueeinstein added a commit to xueeinstein/models that referenced this pull request May 2, 2018
* 'master' of https://github.com/tensorflow/models: (404 commits)
  official/mnist: Updates with the release of TensorFlow 1.8.
  Internal changes to slim and object detection (tensorflow#4100)
  catch cpuinfo ImportError (tensorflow#4138)
  [samples/core/get_starter/eager]: Update with API simplifications in 1.8
  Add vincentvanhoucke as owner for research/marco
  Add marco subdirectory to README.md
  Create request.json
  Create jpeg2json.py
  Fix width / height.
  Create README.md
  Add new import paths to mnist_tpu.py (tensorflow#4133)
  fix model call (tensorflow#4132)
  Remove useless fields in resnet_model (tensorflow#4110)
  official/mnist: Add input_shape parameter to initial layer (tensorflow#4104) (tensorflow#4118)
  Increase minimum TF version for DEFINE_enum and rename variable mappings for change to RNN variable names. (tensorflow#4123)
  fix import errors
  Minor update the resnet runloop. (tensorflow#4113)
  Two new plot-generating scripts and changes in support of the ICLR poster. (tensorflow#4092)
  Add export savedmodel to wide_deep (tensorflow#4041)
  Fix 2 typos
  ...
@qlzh727 qlzh727 deleted the resnet-enhance branch May 3, 2018 17:18
omegafragger pushed a commit to omegafragger/models that referenced this pull request May 15, 2018
1. trainning hooks and train/eval function does not need to be
declared several times.
2. change to use tf.logging.info instead of print
3. Show the current index and total count of training cycle, which
give user some hint about where they are in the whole process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants